-
Notifications
You must be signed in to change notification settings - Fork 1.3k
don't scale when adding to sprite atlas #3530
Conversation
Also fixes #3513? |
@ansis Can SpriteAtlas::bind be unconditionally called with linear=true? |
What about this scaling code? |
Yes, except for #3528
Using nearest neighbour filtering is clearer when icons copied at their original size. This small bit of extra clarity matters since icons are already pretty small.
yeah, that needs to be removed. |
bd112e4
to
fc20199
Compare
The nearest neighbour scaling code is removed in fc20199 |
fc20199
to
1db89b0
Compare
@jfirebaugh I think this should be good now. Want to take another look? |
int dstI = dstY * dstStride + dstX; | ||
int x, y; | ||
|
||
if (wrap && false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, good catch. I'll remove and add a render test to catch this kind of bug: mapbox/mapbox-gl-test-suite#72
scaling.hpp is removed in 0930972 the wrapping bug is fixed in e16a487 and covered with a new render test: mapbox/mapbox-gl-test-suite@a7e5668 do you see anything else or can this be squashed and merged (once tests ci passes)? |
LGTM |
e16a487
to
53d2f53
Compare
53d2f53
to
583ee11
Compare
583ee11
to
e577354
Compare
Don't scale images when adding them to the sprite atlas and make the sprite atlas match -js.
fix #3164 and port https://github.com/mapbox/mapbox-gl-js/pull/1919/files
can you review @jfirebaugh?